[PATCH] D31011: recommend using llvm-ar when finding undefined references and empty archives

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

Let's try this. LGTM.



================
Comment at: ELF/InputFiles.cpp:565
+
+  if (NoSymbols) Config->ArchiveWithoutSymbolsSeen = true;
 }
----------------
Format.

Let's eliminate the local varaible. You could replace `NoSymbols` with `File->symbols().empty()`. `File->symbols()` is cheap so you don't need to save time here.


================
Comment at: ELF/Relocations.cpp:623
+              " the archive. For example, if you are using LLVM"
+              " bitcode objects (such as created by -flto), you may "
+              " need to use llvm-ar or GNU ar with a plugin.");
----------------
Remove the space before ".


https://reviews.llvm.org/D31011