[PATCH] D30121: [asan] Fix dead stripping of globals on Linux.

[Evgeniy Stepanov via Phabricator via llvm-commits]

eugenis marked an inline comment as done.
eugenis added inline comments.


================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:129
+// ASan version script has __asan_* wildcard. Triple underscore prevents
+// exporting of this _local_ symbol.
 static const char *const kAsanGlobalsRegisteredFlagName =
----------------
pcc wrote:
> What happens if you use double underscore? I would have thought that hidden visibility was enough to prevent this symbol from being exported.
/usr/bin/ld.gold: warning: Cannot export local symbol '__asan_globals_registered'


Repository:
  rL LLVM

https://reviews.llvm.org/D30121