[PATCH] D31027: [ThinLTO] Add support for emitting minimized bitcode for thin link

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 16 14:32:48 PDT 2017


tejohnson added inline comments.


================
Comment at: lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:351
+  W.writeModule(&M, /*ShouldPreserveUseListOrder=*/false, &Index,
+                /*GenerateHash=*/true, &ModHash);
+  W.writeModule(MergedM.get());
----------------
pcc wrote:
> Will this cause us to write uninitialized memory as the module hash for the full module?
Gah, I should have 0 initialized this above! Ditto for the other location in this file. Must be getting lucky in my tests. Will fix


https://reviews.llvm.org/D31027





More information about the llvm-commits mailing list