[PATCH] D31045: LTO: Create temporary cache files in the cache directory instead of $TMPDIR.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 16 11:31:07 PDT 2017


pcc added a comment.

In https://reviews.llvm.org/D31045#702988, @mehdi_amini wrote:

> That's nice! LGTM.
>
> I wonder though if we shouldn't have the cache pruning take a "blacklist" of patterns and ignore these files. I wouldn't want one linker process to delete temporary files from another one (Unlikely to happen I guess since LRU though).


Probably the simplest thing we could do to avoid this problem is to create the temporaries in a subdirectory of the cache directory, and have the pruning ignore subdirectories. I agree with you that this is unlikely though.


https://reviews.llvm.org/D31045





More information about the llvm-commits mailing list