[PATCH] D30667: GVNHoist: handle basic blocks with UnreachableInst

[Sanjoy Das via Phabricator via llvm-commits]

sanjoy added a comment.

In https://reviews.llvm.org/D30667#700016, @hfinkel wrote:

> There is? We could propagate the unreachableness of this function to its callsites, but I don't see what that has to do with the value of the function argument.




In https://reviews.llvm.org/D30667#701680, @dberlin wrote:

> Okay, so to close this out, what would we like to do about isGuaranteedToTransferExecutionToSuccessor?
>  Continue have it return false?
>
> Past that, it's clear additional bugs should be filed against gvnhoist.


My inclination would be to have it explicitly (with a nice comment) return true.  That would make bugs like the GVNHoist one we're talking about here more obviously buggy.


Repository:
  rL LLVM

https://reviews.llvm.org/D30667