[PATCH] D31020: Support: Add a cache pruning policy parser.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: llvm/lib/Support/CachePruning.cpp:37
 
+static Expected<std::chrono::seconds> parseInterval(StringRef Interval) {
+  if (Interval.empty())
----------------
pcc wrote:
> mehdi_amini wrote:
> > Why "Interval"? It seems that you're parsing a "time" or a "duration"?
> They're synonyms for the most part, but it looks like "duration" is the term used by the stdlib and distinguishes from the pruning interval, so I've switched to it.
OK.
(maybe because I'm not a native speaker, I thought about "interval" as being synonym to "range", so rather having a begin and an end)


Repository:
  rL LLVM

https://reviews.llvm.org/D31020