[PATCH] D30747: TargetInstrInfo: Provide default implementation of isTailCall().

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added a comment.

In https://reviews.llvm.org/D30747#702333, @dberris wrote:

> LGTM -- I suspect this doesn't break the compiler-rt tests for XRay?


Can I even run them on a mac? I also don't have PPC hardware available. But we surely have buildbots for that (and if not I blame someone else for the lack of bots).



================
Comment at: include/llvm/Target/TargetInstrInfo.h:1499-1501
+  /// Determines whether \p Inst is a tail call instruction. There is no need to
+  /// override this method, unless the target doesn't model the isCall/isReturn
+  /// flags correctly!
----------------
dberris wrote:
> Can we make this comment more direct? Something like:
> 
> "Override this method for targets where tail calls are not always both return and call instructions."
Ok how about

"Override this method on targets that do not properly set MCID::Return and MCID::Call on tail call instructions."

to not give the impression that this is recommended.


Repository:
  rL LLVM

https://reviews.llvm.org/D30747