[llvm] r297887 - NFC: Corrects comments that were supposed to go in with earlier commit.
Adrian McCarthy via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 15 13:29:06 PDT 2017
Author: amccarth
Date: Wed Mar 15 15:29:06 2017
New Revision: 297887
URL: http://llvm.org/viewvc/llvm-project?rev=297887&view=rev
Log:
NFC: Corrects comments that were supposed to go in with earlier commit.
Modified:
llvm/trunk/lib/DebugInfo/PDB/Native/NativeCompilandSymbol.cpp
Modified: llvm/trunk/lib/DebugInfo/PDB/Native/NativeCompilandSymbol.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/PDB/Native/NativeCompilandSymbol.cpp?rev=297887&r1=297886&r2=297887&view=diff
==============================================================================
--- llvm/trunk/lib/DebugInfo/PDB/Native/NativeCompilandSymbol.cpp (original)
+++ llvm/trunk/lib/DebugInfo/PDB/Native/NativeCompilandSymbol.cpp Wed Mar 15 15:29:06 2017
@@ -1,4 +1,4 @@
-//===- NativeCompilandSymbol.h - Native impl of PDBCompilandSymbol -C++ -*-===//
+//===- NativeCompilandSymbol.cpp - Native impl for compilands ---*- C++ -*-===//
//
// The LLVM Compiler Infrastructure
//
@@ -26,9 +26,10 @@ bool NativeCompilandSymbol::isEditAndCon
uint32_t NativeCompilandSymbol::getLexicalParentId() const { return 0; }
-// DIA, which this API was modeled after, uses counter-intuitive meanings for
-// IDiaSymbol::get_name and IDiaSymbol::get_libraryName, which is why these
-// methods may appear to be cross-mapped.
+// The usage of getObjFileName for getLibraryName and getModuleName for getName
+// may seem backwards, but it is consistent with DIA, which is what this API
+// was modeled after. We may rename these methods later to try to eliminate
+// this potential confusion.
std::string NativeCompilandSymbol::getLibraryName() const {
return Module.Info.getObjFileName();
More information about the llvm-commits
mailing list