[PATCH] D30446: [IndVars] Do not branch on poison

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 15 12:51:30 PDT 2017


efriedma added a comment.

I guess first off, I'd like to take a step back and ask: do we need to do this transform at all?  We're using some very complicated logic to conditionally rewrite an induction variable in terms of another induction variable... and then LSR will rewrite all the induction variables from scratch.  This also seems difficult to test effectively: if we incorrectly rewrite an induction variable to something which could be poison, it'll almost always work, except in obscure cases.


https://reviews.llvm.org/D30446





More information about the llvm-commits mailing list