[PATCH] D30970: [AMDGPU] Do not emit isa info as code object metadata

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 15 09:25:38 PDT 2017


arsenm added a comment.

In https://reviews.llvm.org/D30970#701589, @yaxunl wrote:

> LGTM.
>
> Do we have a general guideline what should be in metadata and what should not? Do we assume that end user should be able to manually craft the metadata when they write the ISA assembly by hand?


I'm not sure why we need to encode some of these static hardware properties into it. Why doesn't the runtime/debugger know these already?


https://reviews.llvm.org/D30970





More information about the llvm-commits mailing list