[PATCH] D30939: [ELF] - Split struct In<ELFT> to have templated and non-templated sections areas.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 15 07:27:34 PDT 2017


grimar added a comment.

In https://reviews.llvm.org/D30939#700740, @ruiu wrote:

> This removes template parameter from only three sections among 27 sections, and now you have to append `X` everywhere. Is this really worth it? I wonder if we should just wait for C++14 template variable.


After today there are 13 such sections. The approach of splitting In structure is itself very usefull. I showed that in https://reviews.llvm.org/D30982.
I applied @evgeny777 suggestion to have base and derived class to reduce amount of changes required.


https://reviews.llvm.org/D30939





More information about the llvm-commits mailing list