[PATCH] D30967: [ELF] Update tests to work even with modified defaults

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: test/ELF/merge-reloc.s:71
 
-        .section        .data.1,"aM", at progbits,4
+        .section        .data.1,"awM", at progbits,4
         .align  4
----------------
LLD does not accept writable mergeable sections (*). Even though this test does not depend on that limitation (because you are passing the -r option), it doesn't make much sense to pass an object file that is considered invalid by LLD.

* https://github.com/llvm-project/llvm-project/blob/7744f439b1ad2abd6228f4b291202f7ad73c5814/lld/ELF/InputFiles.cpp#L254

You want to change this to .rodata instead to keep the original intention of this test.


Repository:
  rL LLVM

https://reviews.llvm.org/D30967