[PATCH] D30384: [asan] Add an interceptor for strtok

Kostya Serebryany via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 14 18:29:27 PDT 2017


kcc added inline comments.


================
Comment at: test/asan/TestCases/strtok.c:22
+
+// test overflow in delimiter
+void test1() {
----------------
alekseyshl wrote:
> Why other tests do not have comments? Please split them into separate files and add a top line comment explaining what exactly is tested.
Not worth it, IMHO
But what I did miss is that this test does "%clang_asan %s -o %t" 5 times, while 1 is enough. 


https://reviews.llvm.org/D30384





More information about the llvm-commits mailing list