[llvm] r297786 - [globalisel] LLVM_BUILD_GLOBAL_ISEL=OFF should prevent GlobalISel instruction selector from being declared.

[Daniel Sanders via llvm-commits]

Hi Quentin,

Sure, that should be easy to do.

> On 14 Mar 2017, at 16:33, Quentin Colombet <qcolombet at apple.com> wrote:
> 
> Hi Daniel,
> 
> Instead of those ifdefs, could we have the .inc being somehow empty but still generated with globalisel off?
> 
> Cheers,
> -Quentin
> 
>> On Mar 14, 2017, at 3:09 PM, Daniel Sanders via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>> 
>> Author: dsanders
>> Date: Tue Mar 14 17:09:29 2017
>> New Revision: 297786
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=297786&view=rev
>> Log:
>> [globalisel] LLVM_BUILD_GLOBAL_ISEL=OFF should prevent GlobalISel instruction selector from being declared.
>> 
>> Modified:
>>   llvm/trunk/lib/Target/AArch64/AArch64InstructionSelector.h
>>   llvm/trunk/lib/Target/X86/X86InstructionSelector.h
>> 
>> Modified: llvm/trunk/lib/Target/AArch64/AArch64InstructionSelector.h
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64InstructionSelector.h?rev=297786&r1=297785&r2=297786&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/Target/AArch64/AArch64InstructionSelector.h (original)
>> +++ llvm/trunk/lib/Target/AArch64/AArch64InstructionSelector.h Tue Mar 14 17:09:29 2017
>> @@ -11,6 +11,8 @@
>> /// AArch64.
>> //===----------------------------------------------------------------------===//
>> 
>> +#ifdef LLVM_BUILD_GLOBAL_ISEL
>> +
>> #ifndef LLVM_LIB_TARGET_AARCH64_AARCH64INSTRUCTIONSELECTOR_H
>> #define LLVM_LIB_TARGET_AARCH64_AARCH64INSTRUCTIONSELECTOR_H
>> 
>> @@ -66,3 +68,4 @@ private:
>> } // end namespace llvm
>> 
>> #endif // LLVM_LIB_TARGET_AARCH64_AARCH64INSTRUCTIONSELECTOR_H
>> +#endif // LLVM_BUILD_GLOBAL_ISEL
>> 
>> Modified: llvm/trunk/lib/Target/X86/X86InstructionSelector.h
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86InstructionSelector.h?rev=297786&r1=297785&r2=297786&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/Target/X86/X86InstructionSelector.h (original)
>> +++ llvm/trunk/lib/Target/X86/X86InstructionSelector.h Tue Mar 14 17:09:29 2017
>> @@ -10,6 +10,7 @@
>> /// This file declares the targeting of the InstructionSelector class for X86.
>> //===----------------------------------------------------------------------===//
>> 
>> +#ifdef LLVM_BUILD_GLOBAL_ISEL
>> #ifndef LLVM_LIB_TARGET_X86_X86INSTRUCTIONSELECTOR_H
>> #define LLVM_LIB_TARGET_X86_X86INSTRUCTIONSELECTOR_H
>> 
>> @@ -59,3 +60,4 @@ private:
>> } // end namespace llvm
>> 
>> #endif // LLVM_LIB_TARGET_X86_X86INSTRUCTIONSELECTOR_H
>> +#endif // LLVM_BUILD_GLOBAL_ISEL
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>