[PATCH] D30952: Native PDB reader was swapping module and object file names

Adrian McCarthy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 14 13:37:29 PDT 2017


amccarth created this revision.

The native PDB reader code had inadvertently swapped the module names with the object file names.  This corrects that and updates the affected tests.

Given some of the examples, it's easy to understand how this could be confusing.  For the "main" object, the module name and the object name are the same.  For certain Windows and MS CRT APIs, the module is a .lib but the object file is an import from a DLL (see Windows API sets <https://msdn.microsoft.com/en-us/library/windows/desktop/hh802935(v=vs.85).aspx>).


https://reviews.llvm.org/D30952

Files:
  llvm/lib/DebugInfo/PDB/Native/ModInfo.cpp
  llvm/test/DebugInfo/PDB/pdb-yaml-symbols.test
  llvm/test/DebugInfo/PDB/pdbdump-headers.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30952.91765.patch
Type: text/x-patch
Size: 31826 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170314/8d83975e/attachment.bin>


More information about the llvm-commits mailing list