[PATCH] D30630: [XRay][compiler-rt] Runtime changes to support custom event logging

[Tim Shen via Phabricator via llvm-commits]

timshen added inline comments.


================
Comment at: lib/xray/xray_fdr_logging.cc:508
+  case XRayEntryType::CUSTOM_EVENT:
+    // FIXME: This never should occur. This would imply a patching bug, so at
+    // this point we proceed as if we're still doing the right thing but really
----------------
Do you want to assert here?


================
Comment at: lib/xray/xray_trampoline_x86_64.S:205
+  .cfi_startproc
+	pushq %rbp
+	.cfi_def_cfa_offset 16
----------------
Why stash rbp, if we don't clobber it?


https://reviews.llvm.org/D30630