[lld] r297723 - [ELF] - Simplify LinkerScriptBase::getDot(). NFC.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 14 11:08:45 PDT 2017


Then maybe you can remove getDot and use Dot directly?

On Tue, Mar 14, 2017 at 3:05 AM, George Rimar via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: grimar
> Date: Tue Mar 14 05:05:43 2017
> New Revision: 297723
>
> URL: http://llvm.org/viewvc/llvm-project?rev=297723&view=rev
> Log:
> [ELF] - Simplify LinkerScriptBase::getDot(). NFC.
>
> That makes it not dependent on virtual call,
> keeping logic the same.
>
> Modified:
>     lld/trunk/ELF/LinkerScript.h
>
> Modified: lld/trunk/ELF/LinkerScript.h
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/
> LinkerScript.h?rev=297723&r1=297722&r2=297723&view=diff
> ============================================================
> ==================
> --- lld/trunk/ELF/LinkerScript.h (original)
> +++ lld/trunk/ELF/LinkerScript.h Tue Mar 14 05:05:43 2017
> @@ -239,9 +239,9 @@ protected:
>
>  public:
>    bool hasPhdrsCommands() { return !Opt.PhdrsCommands.empty(); }
> +  uint64_t getDot() { return Dot; }
>
>    virtual uint64_t getSymbolValue(const Twine &Loc, StringRef S) = 0;
> -  uint64_t getDot() { return getSymbolValue("", "."); }
>    virtual bool isDefined(StringRef S) = 0;
>    virtual bool isAbsolute(StringRef S) = 0;
>    virtual OutputSection *getSymbolSection(StringRef S) = 0;
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170314/ac9a2eb5/attachment.html>


More information about the llvm-commits mailing list