[PATCH] D30903: [AArch64] Use alias analysis in the load/store optimization pass.

[Matthias Braun via Phabricator via llvm-commits]

MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D30903#700707, @mcrosier wrote:

> In https://reviews.llvm.org/D30903#699715, @MatzeB wrote:
>
> > Looks good to me. Could you do the sanity checking that we do the right thing in CodeGen and compute the AliasAnalysis information only once for all of CodeGen and not repeat it for different passes? (i.e. -debug-pass=Executions should only show them computed once for all CodeGen passes). Feel free to delegate this task to https://reviews.llvm.org/D30839 if you want ;-)
>
>
> Sure, Matthias.  After this change the Function AA result is freed after the AArch64 load/store optimization pass, rather than the Machine LICM pass (i.e., the change only extends the lifetime of the AA info and doesn't not require it to be recomputed).


That's fine; I just wanted to make sure we do not compute it twice because something in codegen fails to preserve.

The code change itself is obvious. LGTM.


https://reviews.llvm.org/D30903