[PATCH] D30893: [Support][CommandLine] Make it possible to get error messages from ParseCommandLineOptions when ignoring errors.

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: lib/Support/CommandLine.cpp:2182
+  std::string Errs;
+  raw_string_ostream OS(Errs);
+  llvm::cl::ParseCommandLineOptions(argc, argv, StringRef(Overview), &OS);
----------------
Use raw_null_ostream instead.


================
Comment at: unittests/Support/CommandLineTest.cpp:303
+  std::string Errs;
+  raw_string_ostream OS(Errs);
+
----------------
Use raw_null_ostream, here and below.

Actually, can you pick one or two unit tests and test that we get an error message in the error stream?


https://reviews.llvm.org/D30893