[PATCH] D30943: [ARM] Fix for branch label dissassembly for Thumb targets

[Sam Parker via Phabricator via llvm-commits]

samparker accepted this revision.
samparker added a comment.
This revision is now accepted and ready to land.

Hi Andre,

Thanks for working on this.  It would be be nice to have isConditonalBranch and isUnconditionalBranch implemented but, there as there was no specific thumb handling previously, it can definitely wait. LGTM with just the small comment change, no need to re-review.

cheers,
sam



================
Comment at: lib/Target/ARM/MCTargetDesc/ARMMCTargetDesc.cpp:279
+    int64_t Imm = Inst.getOperand(0).getImm();
+    Target = Addr+Imm+4; // In ARM mode the PC is always off by 4 bytes.
+    return true;
----------------
thumb mode


https://reviews.llvm.org/D30943