[PATCH] D30754: SamplePGO ThinLTO ICP fix for local functions.

[Dehao Chen via Phabricator via llvm-commits]

danielcdh added inline comments.


================
Comment at: include/llvm/IR/ModuleSummaryIndex.h:571
                              std::unique_ptr<GlobalValueSummary> Summary) {
     GlobalValueMap[GlobalValue::getGUID(ValueName)].push_back(
         std::move(Summary));
----------------
I also added a call to addOriginalName here as it should be the same as the other instance.


================
Comment at: include/llvm/ProfileData/SampleProfReader.h:287
+    // The function name may have been updated by adding suffix. In sample
+    // profile, the function names are all stripped, so we need to strip
+    // the function name suffix before matching with profile.
----------------
tejohnson wrote:
> Are they stripped, or just not yet promoted and renamed?
They should be all stripped. As discussed offline, if they are not stripped, we need to have a reliable way to map the unstripped name back to IR, which is undesirable.


https://reviews.llvm.org/D30754