[PATCH] D30892: [ELF] - Make Bss and BssRelRo sections to be synthetic (#3).

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/Relocations.cpp:483
+  BssSection<ELFT> *Sec = IsReadOnly ? In<ELFT>::BssRelRo : In<ELFT>::Bss;
+  size_t Off = Sec->reserveSpace(SS->getAlignment<ELFT>(), SymSize);
 
----------------
ruiu wrote:
> I remember that last time I had to change this type from size_t to uintX_t because your previous change broke buildbots.
Right, thanks.


================
Comment at: ELF/SyntheticSections.h:165
+  bool empty() const override { return getSize() == 0; }
+  size_t reserveSpace(uintX_t AddrAlign, size_t Size);
   size_t getSize() const override { return Size; }
----------------
ruiu wrote:
> Rafael made a change to rename AddrAlign Alignment. Please take a look at that change and make your change consistent with that.
Done.


https://reviews.llvm.org/D30892