[PATCH] D30905: stable-merge-request.sh: Add a script for submitting merge requests via bugzilla

[Tom Stellard via Phabricator via llvm-commits]

tstellar added inline comments.


================
Comment at: utils/release/stable-merge-request.sh:245
+  --summary "${bug_summary}" \
+  -l "Is this patch OK to merge to the $stable_version branch?" \
+	$bugzilla_assigned_to \
----------------
hans wrote:
> I'm a bit torn on using the Bugzilla for merge requests. On the one hand I can see the benefit of having an issue opened for each merge request to keep track of which ones are open and which ones are done. On the other hand, I don't like the lack of context and visibility. For a bug like "Please merge rXXX", I'll have to search my inbox to see what rXXX is anyway. And the author of rXXX might not be notified about the request. Also, the discussion on that bug does not get sent to any mailing list, so later searches for rXXX will not show the merge discussion.
> 
> Having said that, I think this script will help though.
> 
> A few ideas:
> 
> 1) It would be awesome if the subject of the bug could include the first line of the commit message, and the body of the bug could quote the full commit message. I think this should be farily easy to get with some svn invocation.
> 
> 2) Could the commit author be added as a cc on the bug or otherwise get a notification? I realize this might be tricky.. we might want to cc the release person though.
> 
> And while I've expressed some skepticism, I think one process is better than two, so maybe the script should simple be called merge-request.sh and be used for the major releases too.
For me, it's much easier to stay organized when the merge requests are in  bugzilla, because there is a clear record of what has been done and what needs to be done.  It also allows for other people to check in and easily see which requests are outstanding, without having to look through the mailing list archives.  All the bugs have a link to the commit on phabricator, so that should make it easier to track down.

1. I think adding the  commit message is doable.

2. Automatically adding the author as a cc is tricky because commit emails don't always match the email people use in bugzilla.  I can add an option for to add cc's manually, but I think it would be better to do auto-detection as a follow on improvement.







https://reviews.llvm.org/D30905