[PATCH] D29639: [SelectionDAG] Add a signed integer absolute ISD node

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 13 16:09:24 PDT 2017


efriedma added a comment.

Would it make sense to use ISD::ABS over combineIntegerAbs in X86ISelLowering.cpp?



================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:5514
+    return N0;
+  return SDValue();
+}
----------------
There are a lot of other folds we could do here (e.g. abs(-x) -> abs(x)), but maybe not worth worrying about?


Repository:
  rL LLVM

https://reviews.llvm.org/D29639





More information about the llvm-commits mailing list