[llvm] r297610 - [LV] Set memcheck metadata also for VF==1

Rapaport, Gil via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 13 15:57:36 PDT 2017


Hi Hal,

Definitely; will do - thanks!

Gil

-----Original Message-----
From: Hal Finkel [mailto:hfinkel at anl.gov] 
Sent: Monday, March 13, 2017 15:21
To: Rapaport, Gil <gil.rapaport at intel.com>; llvm-commits at lists.llvm.org
Subject: Re: [llvm] r297610 - [LV] Set memcheck metadata also for VF==1

Hi Gil,

Can you please add a regression test for this change?

  -Hal


On 03/13/2017 05:23 AM, Gil Rapaport via llvm-commits wrote:
> Author: gilr
> Date: Mon Mar 13 05:23:46 2017
> New Revision: 297610
>
> URL: http://llvm.org/viewvc/llvm-project?rev=297610&view=rev
> Log:
> [LV] Set memcheck metadata also for VF==1
>
> This commit is a follow-up on r297580. It fixes the FIXME added 
> temporarily by that commit to keep the removal of Unroller's 
> specialized version of
> scalarizeInstruction() an NFC. See https://reviews.llvm.org/D30715 for details.
>
> Modified:
>      llvm/trunk/lib/Transforms/Vectorize/LoopVectorize.cpp
>
> Modified: llvm/trunk/lib/Transforms/Vectorize/LoopVectorize.cpp
> URL: 
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Vectoriz
> e/LoopVectorize.cpp?rev=297610&r1=297609&r2=297610&view=diff
> ======================================================================
> ========
> --- llvm/trunk/lib/Transforms/Vectorize/LoopVectorize.cpp (original)
> +++ llvm/trunk/lib/Transforms/Vectorize/LoopVectorize.cpp Mon Mar 13 
> +++ 05:23:46 2017
> @@ -3167,11 +3167,7 @@ void InnerLoopVectorizer::scalarizeInstr
>           auto *NewOp = getScalarValue(Instr->getOperand(op), Part, Lane);
>           Cloned->setOperand(op, NewOp);
>         }
> -      // FIXME: Limiting the versioning metadata to VF > 1 is incorrect. It was
> -      // added as part of removing Unroller's specialized version of this
> -      // method which was not setting versioning metadata.
> -      if (VF > 1)
> -        addNewMetadata(Cloned, Instr);
> +      addNewMetadata(Cloned, Instr);
>   
>         // Place the cloned scalar in the new loop.
>         Builder.Insert(Cloned);
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

--
Hal Finkel
Lead, Compiler Technology and Programming Languages Leadership Computing Facility Argonne National Laboratory

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.


More information about the llvm-commits mailing list