[PATCH] D21723: [RFC] Enhance synchscope representation

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: include/llvm/Bitcode/LLVMBitCodes.h:381
+  /// First encoded value for target specific synchronization scope.
+  SYNCHSCOPE_FIRSTTARGETSPECIFIC = 2
 };
----------------
mehdi_amini wrote:
> mehdi_amini wrote:
> > if the plan is to be able to add new scopes (cf previous question), how is it supposed to be translated on the encoding side?
> I think I mentioned in the past using target specific strings instead of integer in textual and bitcode serialization, why was this ruled out? This was intended to addressed such issues (and make the textual IR more readable)
This was done and then reverted to this plan. I think using a string is overkill and would make the textual IR less readable. Other places in the IR that use string-like inputs refer to them through metadata nodes, which requires indirection to see what it actually is. As it is this isn't really different from target defined address space IDs today.


https://reviews.llvm.org/D21723