[PATCH] D30785: [DWARF] Versioning for DWARF constants; verify FORMs

[Robinson, Paul via llvm-commits]

We don't use ref_sig8 (or any signatures) for "externally defined" types any more, so what David says sound fine to me.

-- adrian

Unfortunately, llvm/test/DebugInfo/X86/externaltyperef.ll disagrees with that statement; DwarfUnit::addDIETypeSignature still has an overload with a 'StringRef Identifier' parameter that emits form ref_sig8, and DwarfUnit::constructTypeDIE still calls that overload for external type refs.  So I'm not sure what you are saying here.
Has the design evolved but the code hasn't caught up yet?
Thanks,
--paulr

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170313/ff94324a/attachment.html>