[PATCH] D30908: [llvm-pdbdump] Add the beginning of PDB diffing support

[Zachary Turner via Phabricator via llvm-commits]

zturner updated this revision to Diff 91622.
zturner added a comment.

Minor updates.

As one more point about "why not just diff the YAML", I just ran pdb2yaml and yaml2pdb on a random PDB on my drive.  Then I ran llvm-pdbdump diff on it.  With just the code in this patch, I get the following output:

  Found 8 common streams.  Searching for intra-stream differences.
    DBI Stream (Left: 283128 bytes, Right: 160570 bytes)
    Named Stream "/names" (Left: 58244 bytes, Right: 55870 bytes)
    Old MSF Directory (Left: 40 bytes, Right: 0 bytes)
    PDB Stream (Left: 118 bytes, Right: 114 bytes)
    TPI Stream (Left: 382784 bytes, Right: 382632 bytes)

Note that the TPI stream on the left (the original file) is 152 bytes larger.  If I use pdb2yaml again on the new file and diff their contents, nothing appears different about the TPI stream.  So we need other tools to figure this kind of thing out.


https://reviews.llvm.org/D30908

Files:
  llvm/tools/llvm-pdbdump/CMakeLists.txt
  llvm/tools/llvm-pdbdump/Diff.cpp
  llvm/tools/llvm-pdbdump/Diff.h
  llvm/tools/llvm-pdbdump/LLVMOutputStyle.cpp
  llvm/tools/llvm-pdbdump/LLVMOutputStyle.h
  llvm/tools/llvm-pdbdump/StreamUtil.cpp
  llvm/tools/llvm-pdbdump/StreamUtil.h
  llvm/tools/llvm-pdbdump/llvm-pdbdump.cpp
  llvm/tools/llvm-pdbdump/llvm-pdbdump.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30908.91622.patch
Type: text/x-patch
Size: 27886 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170313/835a65f3/attachment.bin>