[PATCH] D30851: [ELF] Support ABSOLUTE on the right hand side in linkerscripts

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Generally looking good, but this might conflict with https://reviews.llvm.org/D30891. Rafael?



================
Comment at: ELF/LinkerScript.cpp:1829
     return [=] { return ScriptBase->getHeaderSize(); };
+  if (Tok == "ABSOLUTE") {
+    expect("(");
----------------
Can you add this at the start of this list? They should be sorted alphabetically. I'll do that later.


================
Comment at: ELF/LinkerScript.cpp:1830
+  if (Tok == "ABSOLUTE") {
+    expect("(");
+    Expr E = readExpr();
----------------
You can use `readParenExpr`.


Repository:
  rL LLVM

https://reviews.llvm.org/D30851