[PATCH] D30667: GVNHoist: handle basic blocks with UnreachableInst

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 13 13:03:54 PDT 2017


efriedma added a comment.

This is definitely papering over the problem; for example, take the given testcase, and replace the "unreachable" with "br label %exit".

I would say it makes more sense to return false, as opposed to true... but only because there aren't any successors to transfer execution to.


Repository:
  rL LLVM

https://reviews.llvm.org/D30667





More information about the llvm-commits mailing list