[PATCH] D30895: [ELF] - Step to combine LinkerScript and LinkerScriptBase

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 13 11:44:12 PDT 2017


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/LinkerScript.h:239-240
+  bool hasPhdrsCommands() { return !Opt.PhdrsCommands.empty(); }
+
+public:
+  virtual uint64_t getSymbolValue(const Twine &Loc, StringRef S) = 0;
----------------
Why two "public" labels?


https://reviews.llvm.org/D30895





More information about the llvm-commits mailing list