[PATCH] D30226: [BranchFolding] Merge debug locations from common tail instead of removing

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

Replied.



================
Comment at: lib/CodeGen/BranchFolding.cpp:762
+
+  std::vector<MachineBasicBlock::iterator> NextCommonInsts(SameTails.size());
+  for (unsigned int i = 0 ; i != SameTails.size() ; ++i) {
----------------
I think the right way forward is to commit it like this and then follow-up by an NFC comment that reformats the comments according to the coding guidelines. (No need for a pre-commit review IMO)


================
Comment at: lib/CodeGen/BranchFolding.cpp:763
+  std::vector<MachineBasicBlock::iterator> NextCommonInsts(SameTails.size());
+  for (unsigned int i = 0 ; i != SameTails.size() ; ++i) {
+    if (i != commonTailIndex)
----------------
twoh wrote:
> aprantl wrote:
> > I think local variables should be captialized.
> I kept 'i' small here for the consistency as well.
see above.


https://reviews.llvm.org/D30226