[PATCH] D30886: [ELF] Pad x86 executable sections with 0xcc int3 instructions

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

I actually tried the .exact same thing last week and observed a significant (more than 10%) performance regression, probably due to the regression of memory locality. Can you measure the performance on a multiprocessor machine?



================
Comment at: ELF/OutputSections.cpp:244
+  else if (Flags & SHF_EXECINSTR)
+    fill(Buf, this->Size, Target->DefaultExecutableFill);
 
----------------
I prefer `TrapInstr` over `DefaultExecutableFiller` as it is more concrete than than "the default executable filler".


https://reviews.llvm.org/D30886