[PATCH] D30871: Add forgetBlock in PredIteratorCache.

Xin Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 12 10:01:55 PDT 2017


trentxintong added a comment.

In https://reviews.llvm.org/D30871#698856, @dberlin wrote:

> Hmmm, actually, i bet, for jump threading, the way it caches preds is slower than counting them repeatedly.
>  If it just cached the count, that would likely be fast, but i expect the copying is slower than the counting,.


There are some opportunities for caching the basicblock* list in jump threading (In addtion to the count). But we also need to do the copy ... I will wait for the outcome of your investigation in https://reviews.llvm.org/D30873


https://reviews.llvm.org/D30871





More information about the llvm-commits mailing list