[PATCH] D30468: Simplify the CFG after loop pass cleanup.

[Davide Italiano via Phabricator via llvm-commits]

davide requested changes to this revision.
davide added a comment.
This revision now requires changes to proceed.

I agree with what Simon said. Some comments inline.



================
Comment at: test/Other/pr32085.ll:1-2
+; RUN: opt -O2 -S < %s | FileCheck %s
+; In PR32085 we were getting single-entry-single-exit basic blocks due to the
+; lack of cleanup after some loop transformations.
----------------
Not a very big fan of tests using `-O2`.
It's not the first time this has caused headaches to be while working on changes that make this kind of tests failing and tracking down becomes more and more fun.

That said. I think we need some infrastructure for integration testing (which we currently don't have). I also think the tests we have here should be kept as simple as possible to make sure we can debug them later easily.


================
Comment at: test/Other/pr32085.ll:103
+
+attributes #0 = { ssp uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="core-avx2" "target-features"="+aes,+avx,+avx2,+bmi,+bmi2,+cx16,+f16c,+fma,+fsgsbase,+fxsr,+lzcnt,+mmx,+movbe,+pclmul,+popcnt,+rdrnd,+rtm,+sse,+sse2,+sse3,+sse4.1,+sse4.2,+ssse3,+x87,+xsave,+xsaveopt" "unsafe-fp-math"="false" "use-soft-float"="false" }
+attributes #1 = { argmemonly nounwind }
----------------
the attributes should be not really useful, for example (and if some of them are you can probably trim them down).


https://reviews.llvm.org/D30468