[PATCH] D30785: [DWARF] Versioning for DWARF constants; verify FORMs

[Greg Clayton via Phabricator via llvm-commits]

clayborg added a comment.

I wonder since we are adding new macro parameters to some macros if we shouldn't add two params: version and vendor for anything that uses the special versions. Currently you are overloading version with vendor into a single integer, why not add both version and vendor? Then vendor could be

  DWARF_VENDOR_DWARF = 0, // DWARF as ratified by the latest DWARF standard
  DWARF_VENDOR_APPLE = 1,
  DWARF_VENDOR_BORDLAND = 2,
  ...

This would still allow vendors to specify a version value for their user enums.

Other than that it looks nice. It will really help with "llvm-dwarfdump --verify" in the future.


https://reviews.llvm.org/D30785