[PATCH] D29808: WholeProgramDevirt: Add any unsuccessful llvm.type.checked.load devirtualizations to the list of llvm.type.test users.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: llvm/trunk/lib/Transforms/IPO/WholeProgramDevirt.cpp:1114
+                .ConstCSInfo[VC.Args]
+                .SummaryTypeCheckedLoadUsers.push_back(FS);
+      }
----------------
grimar wrote:
> Had to add brackets to compile this under MSVS2015, please see r297451.
> I am not sure I did correct thing commiting the change though, http://llvm.org/docs/GettingStartedVS.html says:
> "You will need Visual Studio 2015 or higher, with the latest Update installed.", and I don't thing I have any updates installed.
> That is the only place in whole LLVM which does not compile for me now though.
> 
Looks good, thanks for the fix.


Repository:
  rL LLVM

https://reviews.llvm.org/D29808