[PATCH] D30521: Introduce llc/ExecuteTestCommands pass

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

Hi Matthias,

I have mixed feeling on the approach. I like being able to use lite and the .mir format to specify the test, but one the other hand I feel like the ExecuteTestCommand pass will become big and hard to understand.
The unittests had this nice property that they are not mixed together (i.e., we shouldn't have a scheduler test with a coalescer test). Here every functionalities will end up in one place and that's what I don't like.

The bottom line is that I like the approach and I would be fine with this as a first step, but we need to think about a way to compartment the different functionalities (e.g., live range testing vs. scheduling testing).
Maybe we could have a high level class test command with bb and insn functionalities and specialization classes for LIS and so on?

Cheers,
-Quentin



================
Comment at: tools/llc/ExecuteTestCommands.cpp:247
+  }
+  report_fatal_error(Twine("Invalid instructio index ") + Twine(N));
+}
----------------
*instruction


Repository:
  rL LLVM

https://reviews.llvm.org/D30521