[PATCH] D30770: Ensure that prefix data is preserved with subsections-via-symbols

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinter.cpp:655
+      // as an alternative entry point to the prefix-data symbol.
+      MCSymbol *PrefixSym = createTempSymbol("prefix");
+      OutStreamer->EmitLabel(PrefixSym);
----------------
I think this will need to call `OutContext.createLinkerPrivateTempSymbol()` because the symbols that `createTempSymbol()` creates will not be emitted to the object file.


================
Comment at: test/CodeGen/AArch64/prefixdata.ll:30
+; MACHO: .subsections_via_symbols
\ No newline at end of file

----------------
Add newline, same with your other test


https://reviews.llvm.org/D30770