[llvm] r297482 - [SelectionDAG] Make SelectionDAG aware of the known bits in USUBO and SSUBO and SUBC.
Amaury Sechet via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 10 09:26:44 PST 2017
Author: deadalnix
Date: Fri Mar 10 11:26:44 2017
New Revision: 297482
URL: http://llvm.org/viewvc/llvm-project?rev=297482&view=rev
Log:
[SelectionDAG] Make SelectionDAG aware of the known bits in USUBO and SSUBO and SUBC.
Summary:
Depends on D30379
This improves the state of things for the sub class of operation.
Reviewers: jyknight, nemanjai, mkuper, spatel, RKSimon, zvi, bkramer
Subscribers: llvm-commits
Differential Revision: https://reviews.llvm.org/D30436
Modified:
llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
llvm/trunk/test/CodeGen/X86/known-bits.ll
Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp?rev=297482&r1=297481&r2=297482&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp Fri Mar 10 11:26:44 2017
@@ -2297,8 +2297,6 @@ void SelectionDAG::computeKnownBits(SDVa
KnownOne &= KnownOne2;
KnownZero &= KnownZero2;
break;
- case ISD::SSUBO:
- case ISD::USUBO:
case ISD::SMULO:
case ISD::UMULO:
if (Op.getResNo() != 1)
@@ -2493,8 +2491,19 @@ void SelectionDAG::computeKnownBits(SDVa
// All bits are zero except the low bit.
KnownZero = APInt::getHighBitsSet(BitWidth, BitWidth - 1);
break;
-
- case ISD::SUB: {
+ case ISD::USUBO:
+ case ISD::SSUBO:
+ if (Op.getResNo() == 1) {
+ // If we know the result of a setcc has the top bits zero, use this info.
+ if (TLI->getBooleanContents(Op.getOperand(0).getValueType()) ==
+ TargetLowering::ZeroOrOneBooleanContent &&
+ BitWidth > 1)
+ KnownZero.setBits(1, BitWidth);
+ break;
+ }
+ LLVM_FALLTHROUGH;
+ case ISD::SUB:
+ case ISD::SUBC: {
if (ConstantSDNode *CLHS = isConstOrConstSplat(Op.getOperand(0))) {
// We know that the top bits of C-X are clear if X contains less bits
// than C (i.e. no wrap-around can happen). For example, 20-X is
Modified: llvm/trunk/test/CodeGen/X86/known-bits.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/known-bits.ll?rev=297482&r1=297481&r2=297482&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/X86/known-bits.ll (original)
+++ llvm/trunk/test/CodeGen/X86/known-bits.ll Fri Mar 10 11:26:44 2017
@@ -247,11 +247,11 @@ define {i32, i1} @knownbits_usubo_ssubo(
; X64: # BB#0:
; X64-NEXT: shlq $32, %rdi
; X64-NEXT: shlq $32, %rsi
-; X64-NEXT: subq %rsi, %rdi
-; X64-NEXT: setb %cl
+; X64-NEXT: cmpq %rsi, %rdi
+; X64-NEXT: setb %al
; X64-NEXT: seto %dl
-; X64-NEXT: leal (%rdi,%rdi), %eax
-; X64-NEXT: orb %cl, %dl
+; X64-NEXT: orb %al, %dl
+; X64-NEXT: xorl %eax, %eax
; X64-NEXT: retq
%1 = shl i64 %a0, 32
%2 = shl i64 %a1, 32
More information about the llvm-commits
mailing list