[PATCH] D30802: [Builtin] Implement lit-test support

[Michał Górny via Phabricator via llvm-commits]

mgorny added a comment.

First of all, thank you for doing this! This was long overdue ;-).

However, after applying your patch I get 2 failures per arch:

  Failing Tests (4):
      Builtins-i386-linux :: cpu_model_test.c
      Builtins-i386-linux :: gcc_personality_test.c
      Builtins-x86_64-linux :: cpu_model_test.c
      Builtins-x86_64-linux :: gcc_personality_test.c

FWICS, cpu_model_test is not strictly a test since it either returns 4 or 3 depending on whether avx2 is supported. So you should probably remove/disable it.

If you don't plan to fix the personality test in this comment, then it would probably be wise to disable it as well.


https://reviews.llvm.org/D30802