[PATCH] D30541: [ELF] - Make Bss and BssRelRo sections to be synthetic (#2).

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 10 06:35:25 PST 2017


grimar updated this revision to Diff 91329.
grimar added a comment.

- Looks reason of PR32167 (AArch64 LLD buildbot broken) was a lost of symbol version information after conversion from SharedSymbol to DefinedRegular.

Previously SharedSymbol had Verdef member, patch changes logic. Currently SharedFile contains mapping from symbol to verdef.
That allows keep version information in a single place. Alternative solution I tried was to have Verdef in DefinedRegular as well, that was not nice IMO.
Probably we may move it to Defined class instead.


https://reviews.llvm.org/D30541

Files:
  ELF/InputFiles.cpp
  ELF/InputFiles.h
  ELF/OutputSections.cpp
  ELF/OutputSections.h
  ELF/Relocations.cpp
  ELF/SymbolTable.cpp
  ELF/SymbolTable.h
  ELF/Symbols.cpp
  ELF/Symbols.h
  ELF/SyntheticSections.cpp
  ELF/SyntheticSections.h
  ELF/Writer.cpp
  test/ELF/version-script-copy-rel.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30541.91329.patch
Type: text/x-patch
Size: 18747 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170310/cd8ee5fc/attachment.bin>


More information about the llvm-commits mailing list