[PATCH] D30790: [LVI] Add an LVI printer pass to capture test LVI cache after transformations

[Artur Pilipenko via Phabricator via llvm-commits]

apilipenko added a comment.

It's worth noting for others that the motivation for the change is a bug we found in JumpThreading LVI cache invalidation. The bug is easily triggered with our downstream changes, but is difficult to trigger it upstream. We need the printer pass to write an isolated upstream test case for this problem.



================
Comment at: include/llvm/Analysis/LazyValueInfo.h:101
 
+  // Print the LVI cache.
+  void printLazyValueInfoCache(const DataLayout &DL, raw_ostream &OS);
----------------
Here and below - /// doxygen documentation comment


================
Comment at: include/llvm/Analysis/LazyValueInfo.h:102
+  // Print the LVI cache.
+  void printLazyValueInfoCache(const DataLayout &DL, raw_ostream &OS);
+
----------------
Here and below - just printCache?


================
Comment at: lib/Analysis/LazyValueInfo.cpp:449
+             << BV.first->getName() << "'\n";
+    }
+
----------------
For the sake of completeness you might also want to print overdefined cache. 


https://reviews.llvm.org/D30790