[PATCH] D30651: [InlineCost, -Oz] Don't take into account the penalty of a fast call of frequently used functions

Evgeny Astigeevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 10 02:48:55 PST 2017


eastig added a comment.

In https://reviews.llvm.org/D30651#697010, @efriedma wrote:

> OptMinSizeThreshold is basically set experimentally; http://reviews.llvm.org/rL288024 is the last time it was adjusted.
>
> I don't think anyone's looked at CallPenalty in a long time; it's possible it's too large at -Oz.


I ran LNT for the patch. There are big code-size regressions in benchmarks written in C++.  So the idea to treat functions with the non-local linkage as having many users needs some research.


https://reviews.llvm.org/D30651





More information about the llvm-commits mailing list