[PATCH] D30802: [Builtin] Implement lit-test support

[Weiming Zhao via Phabricator via llvm-commits]

weimingz added inline comments.


================
Comment at: test/builtins/Unit/lit.cfg:67
+                              build_invocation(clang_builtins_cxxflags)))
+
+# FIXME: move the call_apsr.s into call_apsr.h as inline-asm.
----------------
jroelofs wrote:
> Where does `%run` get expanded?
%run will be run natively by default. If config.emulator is set, then it will be used. (test/lit.common.cfg)


================
Comment at: test/builtins/Unit/lit.cfg:83
+# Only run the tests on supported OSs.
+if config.host_os not in ['Linux', 'Darwin', 'FreeBSD', 'Windows']:
+  config.unsupported = True
----------------
jroelofs wrote:
> Please don't assume that $host == $target... This prevents remote cross testing.
I can remove that. I copied it from asan's lit test. 


https://reviews.llvm.org/D30802