[PATCH] D29023: [Stack Protection] Add diagnostic information for why stack protection was applied to a function

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 10 01:31:20 PST 2017


jhenderson added a comment.

In https://reviews.llvm.org/D29023#696643, @anemet wrote:

> Were these public bots?


Yes - it was some of the PPC bots, although I don't know which ones off the top of my head; possibly all of them.

>> @anemet - do you have any thoughts on how to make the testing more generic?
> 
> I think that we should just pin it to a target.  This is not testing the basic functionality but whether we provide diagnostics about it.

Ok, that's what we ended up doing (we put a REQUIRES: X86 in the tests along with relevant target triple).


Repository:
  rL LLVM

https://reviews.llvm.org/D29023





More information about the llvm-commits mailing list