[PATCH] D30800: Do not use branch metadata to check if a basic block is hot.

Easwaran Raman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 9 17:34:47 PST 2017


eraman accepted this revision.
eraman added a comment.
This revision is now accepted and ready to land.

LGTM after removing the changes to the ProfileSummaryInfoTest.cpp.



================
Comment at: unittests/Analysis/ProfileSummaryInfoTest.cpp:165
   EXPECT_FALSE(PSI.isHotCallSite(CS2, &BFI));
-
-  // Test that adding an MD_prof metadata with a hot count on CS2 does not
----------------
This test is still relevant even after the change. I think you meant to remove it in the other patch - https://reviews.llvm.org/D30799


https://reviews.llvm.org/D30800





More information about the llvm-commits mailing list