[PATCH] D30738: Don't internalize llvm GV's with InternalizeLinkedSymbols
Mehdi AMINI via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 9 16:07:42 PST 2017
mehdi_amini added a comment.
In https://reviews.llvm.org/D30738#697051, @pcc wrote:
> The fix can be simplified to
>
> if (P.first().startswith("llvm."))
> continue;
>
I wouldn't want to see this, this is still duplicating logic. I'd be OK with a helper function`legalToInternalize(GlobalValue &)` that would factor out the logic to decide this.
Repository:
rL LLVM
https://reviews.llvm.org/D30738
More information about the llvm-commits
mailing list