[PATCH] D30738: Don't internalize llvm GV's with InternalizeLinkedSymbols

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: tools/llvm-link/llvm-link.cpp:99
+                                      cl::desc("Suppress all linking warnings"),
+                                      cl::init(false));
 
----------------
Please don't mix these formatting change.

Did you run clang-format on the full file to have these? Usually `git clang-format` will format only the part of the code you change.


================
Comment at: tools/llvm-link/llvm-link.cpp:319
+              IP.internalizeModule(M);
+            }))
       return false;
----------------
Usually we avoid using a Pass outside of the PassManager, can you just call `internalizeModule` with your callback?

Also any reason you're taking the StringSet by value instead of const ref?


Repository:
  rL LLVM

https://reviews.llvm.org/D30738