[PATCH] D30738: Don't internalize llvm GV's with InternalizeLinkedSymbols

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

Thanks, a couple more questions.



================
Comment at: tools/llvm-link/llvm-link.cpp:326
+    } else {
+      Err = L.linkInModule(std::move(M), ApplicableFlags);
+    }
----------------
Why is this needed since linkInModule has a default for the InternalizeCallback parameter?


================
Comment at: tools/llvm-link/llvm-link.cpp:329
+
+    InternalizeLinkedSymbols |= Internalize;
+
----------------
Previously the internalize flag was set before invoking this function from main(). With this being set after the first linkInModule it seems like a behavior change, or am I missing something?


Repository:
  rL LLVM

https://reviews.llvm.org/D30738